Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use uglifyjs-webpack-plugin v1 #3618

Merged
merged 1 commit into from
Jan 11, 2018
Merged

use uglifyjs-webpack-plugin v1 #3618

merged 1 commit into from
Jan 11, 2018

Conversation

viankakrisna
Copy link
Contributor

@viankakrisna viankakrisna commented Dec 17, 2017 •
edited
Loading

as quoted by the readme https://github.com/webpack-contrib/uglifyjs-webpack-plugin:

webpack =< v3.0.0 currently contains v0.4.6 of this plugin under webpack.optimize.UglifyJsPlugin as an alias. For usage of the latest version (v1.0.0), please follow the instructions below. Aliasing v1.0.0 as webpack.optimize.UglifyJsPlugin is scheduled for webpack v4.0.0

The v1 is released on October, so I think it's mature enough to switch to v1 in CRA? or do we want to wait for webpack 4?

Pro:

This allows us to use uglify-es and access to parallel and cache options. Hence improving our build speed.

Con:

I haven't test it yet, but maybe this will break our parsing of uglify error #2650

@viankakrisna viankakrisna mentioned this pull request Jan 3, 2018
Closed
@Timer Timer added this to the 2.0.0 milestone Jan 11, 2018
@Timer Timer merged commit b7d9201 into facebook:master Jan 11, 2018
@Timer
Copy link
Contributor

Timer commented Jan 11, 2018 •
edited
Loading

Oops, accidentally merged this to master. You can find this in next now.

Timer pushed a commit that referenced this pull request Jan 11, 2018
@viankakrisna @Timer
Use uglifyjs-webpack-plugin v1 (#3618)
4dff99c
Timer pushed a commit to Timer/create-react-app that referenced this pull request Jan 11, 2018
@viankakrisna @Timer
Use uglifyjs-webpack-plugin v1 (facebook#3618)
132f5a7
@viankakrisna viankakrisna mentioned this pull request Jan 11, 2018
Closed
Timer pushed a commit to Timer/create-react-app that referenced this pull request Jan 13, 2018
@viankakrisna @Timer
Use uglifyjs-webpack-plugin v1 (facebook#3618)
7ca0800
@existentialism existentialism mentioned this pull request Jan 13, 2018
Merged
@Timer Timer mentioned this pull request Jan 13, 2018
Closed
gaearon pushed a commit that referenced this pull request Jan 13, 2018
@viankakrisna @gaearon
Use uglifyjs-webpack-plugin v1 (#3618)
735cd5d
Timer pushed a commit that referenced this pull request Jan 14, 2018
@viankakrisna @Timer
Use uglifyjs-webpack-plugin v1 (#3618)
d7bff36
gaearon pushed a commit that referenced this pull request Jan 14, 2018
@viankakrisna @gaearon
Use uglifyjs-webpack-plugin v1 (#3618)
44e0728
gaearon pushed a commit that referenced this pull request Jan 14, 2018
@viankakrisna @gaearon
Use uglifyjs-webpack-plugin v1 (#3618)
99b51b6
gaearon pushed a commit that referenced this pull request Jan 14, 2018
@viankakrisna @gaearon
Use uglifyjs-webpack-plugin v1 (#3618)
2b0016e
gaearon pushed a commit that referenced this pull request Jan 14, 2018
@viankakrisna @gaearon
Use uglifyjs-webpack-plugin v1 (#3618)
b6f9a63
Timer pushed a commit to Timer/create-react-app that referenced this pull request Jan 15, 2018
@viankakrisna @Timer
Use uglifyjs-webpack-plugin v1 (facebook#3618)
ff54494
@gaearon gaearon mentioned this pull request Jan 16, 2018
Closed
@tofuness tofuness mentioned this pull request Jan 16, 2018
Closed
@davedoesdev davedoesdev mentioned this pull request Jan 26, 2018
Closed
@KyleAMathews KyleAMathews mentioned this pull request Feb 6, 2018
Closed
@sohkai
Copy link

sohkai commented Feb 21, 2018

Is there any chance of this getting into a 1.1.2 (or similar) release? This will fix a lot of the minifying problems.

@Timer
Copy link
Contributor

Timer commented Feb 22, 2018

No, this will not be released in a 1.1.2 release. Sorry!

This is not a minifying problem, but as that link explains it's a problem with the libraries you're importing.
Due the the sheer amount of improperly published packages in the ecosystem, v2 addresses this. Please engage in the betas and provide feedback!

akstuhl pushed a commit to akstuhl/create-react-app that referenced this pull request Mar 15, 2018
@viankakrisna @akstuhl
Use uglifyjs-webpack-plugin v1 (facebook#3618)
bca7f56
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@viankakrisna @Timer
Use uglifyjs-webpack-plugin v1 (facebook#3618)
42e712a
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@viankakrisna @Timer @sohkai @facebook-github-bot